Skip to content

Commit

Permalink
bump node version to 18
Browse files Browse the repository at this point in the history
  • Loading branch information
H-Shay committed Nov 7, 2023
1 parent 7ca748c commit abb779f
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/mjolnir.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ jobs:
steps:
- uses: actions/checkout@v3

- name: Specifically use node 16 like in the readme.
- name: Specifically use node 18 like in the readme.
uses: actions/setup-node@v3
with:
node-version: '16'
node-version: '18'
- run: yarn install
- run: yarn build
- run: yarn lint
Expand All @@ -29,10 +29,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Specifically use node 16 like in the readme.
- name: Specifically use node 18 like in the readme.
uses: actions/setup-node@v3
with:
node-version: '16'
node-version: '18'
- run: yarn install
- run: yarn test
integration:
Expand All @@ -43,7 +43,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '16'
node-version: '18'
- name: Fetch and build mx-tester (cached across runs)
uses: baptiste0928/cargo-install@v1
with:
Expand All @@ -65,7 +65,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '16'
node-version: '18'
- name: Fetch and build mx-tester (cached across runs)
uses: baptiste0928/cargo-install@v1
with:
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# We can't use alpine anymore because crypto has rust deps.
FROM node:16-slim
FROM node:18-slim
COPY . /tmp/src
RUN cd /tmp/src \
&& yarn install \
Expand Down
2 changes: 1 addition & 1 deletion docs/setup_selfbuild.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
These instructions are to build and run mjolnir without using [Docker](./setup_docker.md).
To build mjolnir, you have to have installed [Node >=16](https://nodejs.org/en/download/), [npm](https://docs.npmjs.com/cli/v7/configuring-npm/install) and [yarn >1.x](https://classic.yarnpkg.com/en/docs/install).
To build mjolnir, you have to have installed [Node >=18](https://nodejs.org/en/download/), [npm](https://docs.npmjs.com/cli/v7/configuring-npm/install) and [yarn >1.x](https://classic.yarnpkg.com/en/docs/install).

Copy the latest release tag from https://github.com/matrix-org/mjolnir/releases/latest/ to use when cloning. For example `v1.6.1` - please check the link for the current version as this mentioned example might be outdated.

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,6 @@
"yaml": "^2.2.2"
},
"engines": {
"node": ">=16.0.0"
"node": ">=18.0.0"
}
}

0 comments on commit abb779f

Please sign in to comment.