Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter out rooms where user was never a member when redacting rooms #551

Merged
merged 5 commits into from
Oct 22, 2024
Merged

Filter out rooms where user was never a member when redacting rooms #551

merged 5 commits into from
Oct 22, 2024

Conversation

H-Shay
Copy link
Contributor

@H-Shay H-Shay commented Oct 18, 2024

No description provided.

@H-Shay H-Shay requested a review from a team as a code owner October 18, 2024 21:15
@H-Shay H-Shay marked this pull request as draft October 18, 2024 21:28
@H-Shay H-Shay marked this pull request as ready for review October 18, 2024 22:06
turt2live
turt2live reviewed Oct 21, 2024
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good! A test to confirm the function picks up join->message->leave->ban specifically would be good, noting that Mjolnir might not auto-redact or actually issue the ban for Reasons™️ (the faster members lookup config option can cause problems).

src/utils.ts Outdated Show resolved Hide resolved
@H-Shay H-Shay requested a review from turt2live October 22, 2024 18:33
turt2live
turt2live approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm - thanks!

test/integration/commands/redactCommandTest.ts Outdated Show resolved Hide resolved
@H-Shay H-Shay merged commit e1dcfc2 into main Oct 22, 2024
5 checks passed
@H-Shay H-Shay deleted the shay/unbounded_redactions branch October 22, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@H-Shay @turt2live