Add SASL EXTERNAL authentication and example #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
approved these changes
Aug 10, 2020
| ).toString('base64')); | ||
| break; | ||
| case 'EXTERNAL': | ||
| self._send('AUTHENTICATE', '+'); |
There was a problem hiding this comment.
Just to be clear, this is just the client saying that it doesn't need to provide a set of authentication credentials because the cert provided does that?
There was a problem hiding this comment.
yep that should be it. the rfc says The mechanism is capable of transferring an authorization identity string. If empty, the client is requesting to act as the identity the server has associated with the client's credentials.
I implemented this looking at how weechat and other clients do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been trying to get my matrix irc relay working on an amazon ec2 server. little did i know that freenode requires sasl auth from certain ip ranges, which include ec2, to prevent abuse. so I tried setting up plain sasl auth but i could not get it to work even after applying the patched described in matrix-org/matrix-appservice-irc#689
I have however figured out that freenode will happily auth you if you use sasl EXTERNAL and attach a certificate to your conn
this PR simply adds a saslType option so you can set it to EXTERNAL if needed.