Disallow panics, unreachables, and expects using clippy lints #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
=======================================
Coverage 90.35% 90.35%
=======================================
Files 34 34
Lines 1990 1990
=======================================
Hits 1798 1798
Misses 192 192 ☔ View full report in Codecov by Sentry. |
This ensures that we don't add panics and expects in the codebase unless we explicitly allow it for each individual invocation.
poljar
force-pushed
the
poljar/disallow-panics-unreachables
branch
from
ca06697 to
3dd42bc
Compare
|
Rebased now that #204 has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we're relatively stable, we can disallow the usage of these quite dangerous invocations.
We don't want to let any of those slip through reviews and it allows people that write PRs know ahead of time that they shouldn't be used.
Depends on #204 since that removes a panic that shouldn't exist.