Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace golint with staticcheck #204

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,10 @@ jobs:
run: go vet ./...

- name: Lint
if: matrix.os == 'ubuntu-latest'
if: matrix.os == 'ubuntu-latest' && matrix.go-version == '1.19.x'
run: |
go install golang.org/x/lint/golint@latest
golint ./...
go install honnef.co/go/tools/cmd/[email protected]
staticcheck -checks=all ./...

- name: Test
run: go test ./...
1 change: 1 addition & 0 deletions example/example.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// Package example demonstrates how to use moq with the go:generate directive.
package example

import "context"
Expand Down
1 change: 1 addition & 0 deletions generate/generate.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// Package generate demonstrates how to use moq with the go:generate directive.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I wrote the same description for this package and the example package. It's actually not clear to me what the difference is between these two packages.

package generate

// In a terminal, run `go generate` in this directory to have
Expand Down
2 changes: 2 additions & 0 deletions internal/registry/registry.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// Package registry provides the ability to encapsulate type information for the
// source and mock destination package.
package registry

import (
Expand Down
1 change: 1 addition & 0 deletions internal/template/template.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// Package template defines the template for the Moq generated code.
package template

import (
Expand Down
1 change: 1 addition & 0 deletions pkg/moq/moq.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// Package moq provides the ability to generate mocks for interfaces.
package moq

import (
Expand Down