Added MP3 file support #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based off of the code from welll/record-encode-audio-from-browser, I’ve clean it up and integrate it to this code using similar function names and coding style. Will update the README and make a pull request to be merged back!
Get it ready for a pull request.
Because I just found out that akrennmair/libmp3lame-js is licensed under LGPL which is in conflict with the original license of the project. The license note should reflect this. Also add a quick note to warn about licensing conflict, and clarify the separate worker for different output format.
|
Does this work on all platforms? |
|
What do you mean by platform? I've tested it using Chrome browser on OSX and Windows and they seem to work fine. That said, everything here is done in JavaScript so it should work on any browser. Please note that there maybe some special licensing requirements for MP3 encoding though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added MP3 audio type support using Lame library as inspired by nusofthq.
I ended up having to rename the exportWAV to exportAudio so that the function for export can be the same between WAV and MP3 worker. It breaks compatibility but makes the code easier to read and understand between the two workers.