-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ES aggregations #601
Open
bompi88
wants to merge
3
commits into
matteodem:master
Choose a base branch
from
bompi88:aggs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
ES aggregations #601
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
import { Cursor } from 'meteor/easysearch:core'; | ||
|
||
/** | ||
* A Cursor that extends the regular EasySearch cursor. This cursor is Elasticsearch specific. | ||
* | ||
* @type {ESCursor} | ||
*/ | ||
class ESCursor extends Cursor { | ||
/** | ||
* Constructor | ||
* | ||
* @param {Mongo.Cursor} hitsCursor Referenced mongo cursor to the regular hits field | ||
* @param {Number} count Count of all documents found in regular hits field | ||
* @param {Object} aggs Raw aggragtion data | ||
* @param {Boolean} isReady Cursor is ready | ||
* @param {Object} publishHandle Publish handle to stop if on client | ||
* | ||
* @constructor | ||
* | ||
*/ | ||
constructor(cursor, count, isReady = true, publishHandle = null, aggs = {}) { | ||
check(cursor.fetch, Function); | ||
check(count, Number); | ||
check(aggs, Match.Optional(Object)); | ||
|
||
super(cursor, count, isReady, publishHandle); | ||
|
||
this._aggs = aggs; | ||
} | ||
|
||
getAggregation(path) { | ||
return this._aggs[path]; | ||
} | ||
|
||
getAggregations() { | ||
return this._aggs; | ||
} | ||
} | ||
|
||
export default ESCursor; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66 changes: 66 additions & 0 deletions
66
packages/easysearch:elasticsearch/lib/search-collection.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
import { SearchCollection } from 'meteor/easysearch:core'; | ||
import ESCursor from './cursor'; | ||
|
||
/** | ||
* A search collection represents a reactive collection on the client, | ||
* which is used by the ReactiveEngine for searching using Elasticsearch. | ||
* | ||
* @type {ESSearchCollection} | ||
*/ | ||
class ESSearchCollection extends SearchCollection { | ||
/** | ||
* Constructor | ||
* | ||
* @param {Object} indexConfiguration Index configuration | ||
* @param {ReactiveEngine} engine Reactive Engine | ||
* | ||
* @constructor | ||
*/ | ||
constructor() { | ||
super(...arguments, false); | ||
} | ||
|
||
/** | ||
* Find documents on the client. | ||
* | ||
* @param {Object} searchDefinition Search definition | ||
* @param {Object} options Options | ||
* | ||
* @returns {ESCursor} | ||
*/ | ||
find(searchDefinition, options) { | ||
if (!Meteor.isClient) { | ||
throw new Error('find can only be used on client'); | ||
} | ||
|
||
let publishHandle = Meteor.subscribe(this.name, searchDefinition, options); | ||
|
||
let count = this._getCount(searchDefinition); | ||
let aggs = this._getAggregation(searchDefinition); | ||
let mongoCursor = this._getMongoCursor(searchDefinition, options); | ||
|
||
if (!_.isNumber(count)) { | ||
return new ESCursor(mongoCursor, 0, false, null, aggs); | ||
} | ||
|
||
return new ESCursor(mongoCursor, count, true, publishHandle, aggs); | ||
} | ||
|
||
/** | ||
* Get the aggregations linked to the search | ||
* | ||
* @params {Object} searchDefinition Search definition | ||
* | ||
* @private | ||
*/ | ||
_getAggregation(searchDefinition) { | ||
const aggsDoc = this._collection.findOne('aggs' + JSON.stringify(searchDefinition)); | ||
if (aggsDoc) { | ||
return aggsDoc.aggs; | ||
} | ||
return {}; | ||
} | ||
|
||
} | ||
|
||
export default ESSearchCollection; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matteodem It seems that the
cursor.count()
returns the initial count value set while instantiating the cursor, so I added a optionalmongoCount
parameter that is set tofalse
by theESCursor
. Is this a satisfiable solution or should I do it otherwise?