fix: fixes anvil-zksync failing on ubuntu-latest #527
Conversation
.github/workflows/release.yml
Outdated
| @@ -41,9 +41,9 @@ jobs: | |||
| ] | |||
| include: | |||
| - arch: x86_64-unknown-linux-gnu | |||
| platform: ubuntu-20.04 | |||
| platform: ubuntu-latest | |||
There was a problem hiding this comment.
Not sure if it's a good idea, using latest recently broke CI in one of other repositories. IMHO it's better to avoid unexpected changes.
Cross.toml
Outdated
| [target.x86_64-unknown-linux-gnu] | ||
| image = "ubuntu:22.04" |
There was a problem hiding this comment.
Might as well use 24.04 at this point, that's also what Github's ubuntu-latest currently points to
| make build-static-${{ matrix.arch }} | ||
| else | ||
| make build-${{ matrix.arch }} | ||
| fi |
There was a problem hiding this comment.
Do you think we shouldn't build static binaries on macOS? I assume openssl is more or less on every modern mac machine but I wouldn't count on it being the same version
There was a problem hiding this comment.
I am not too familiar with any pros / cons but figured we havent had any issue with the macos builds to leave it as it. When I was looking into static builds it seems only prevalent with linux builds.
What 💻
anvil-zksyncfails onubuntu-latestdue to missinglibssl.so.1.1#524Why ✋
anvil-zksyncfails onubuntu-latestdue to missinglibssl.so.1.1#524Evidence 📷
Include screenshots, screen recordings, or
consoleoutput here demonstrating that your changes work as intended