Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

reduce temporary memory requirement for generate_permutation_matrix #24

Merged
merged 2 commits into from
Jan 26, 2024
Merged

reduce temporary memory requirement for generate_permutation_matrix #24

merged 2 commits into from
Jan 26, 2024

Conversation

robik75
Copy link
Member

@robik75 robik75 commented Jan 25, 2024 •
edited
Loading

What ❔

This PR reduces the temporary memory requirement for generate_permutation_matrix to (4 * num_cells + 1) * sizeof::<u32>() bytes.

Why ❔

Less GPU memory usage is good.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Code has been formatted via cargo fmt and linted via cargo clippy.

@robik75 robik75 self-assigned this Jan 25, 2024
@robik75 robik75 requested a review from mcarilli as a code owner January 25, 2024 11:42
mcarilli
mcarilli reviewed Jan 25, 2024
View reviewed changes
src/ops_complex.rs Outdated Show resolved Hide resolved
mcarilli
mcarilli reviewed Jan 25, 2024
View reviewed changes
src/ops_complex.rs Outdated Show resolved Hide resolved
mcarilli
mcarilli reviewed Jan 25, 2024
View reviewed changes
src/ops_complex.rs Outdated Show resolved Hide resolved
@robik75 robik75 merged commit 97bdb63 into main Jan 26, 2024
6 checks passed
@robik75 robik75 deleted the rr-permutations-mem-usage branch January 26, 2024 20:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcarilli mcarilli mcarilli approved these changes

Assignees

@robik75 robik75

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robik75 @mcarilli