This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
build refactoring #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robik75
force-pushed
the
rr-build-refactor
branch
from
1b6ae98 to
5f301b7
Compare
robik75
force-pushed
the
rr-build-refactor
branch
from
7c1fe98 to
abab58e
Compare
popzxc
previously approved these changes
Aug 6, 2024
EmilLuta
approved these changes
Aug 6, 2024
2 tasks
robik75
added a commit
to matter-labs/era-shivini
that referenced
this pull request
Aug 6, 2024
# What ❔ This PR is a follow up to matter-labs/era-cuda#9 and matter-labs/era-boojum-cuda#36 ## Why ❔ All the dependencies need to be updated. ## Checklist - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Code has been formatted via `cargo fmt` and `cargo check`.
robik75
added a commit
to matter-labs/era-shivini
that referenced
this pull request
Aug 6, 2024
# What ❔ This PR is a follow up to matter-labs/era-cuda#9 and matter-labs/era-boojum-cuda#36 ## Why ❔ All the dependencies need to be updated. ## Checklist - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Code has been formatted via `cargo fmt` and `cargo check`. (cherry picked from commit 79910dc)
robik75
added a commit
that referenced
this pull request
Aug 8, 2024
# What ❔ This PR fixes some leftover naming issues from remaining from #36 . ## Checklist - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Code has been formatted via `cargo fmt` and `cargo clippy`.
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This PR re-implements the build process, introducing following features and changes:
no_cudais implemented to allow code compilation and linking without the presence of a CUDA toolkit installation by replacing the CUDA API calls with stubs and completely bypasses native code compilation and linking, replacing all theextern "C"function calls and structures with stubs.0.2.0Why ❔
Compiling and executing non-GPU part of the codebase is desired to enable development work in environments where CUDA toolkit is not installed.
Checklist
cargo fmtandcargo clippy.