Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

NTT housekeeping #17

Merged
merged 6 commits into from
Dec 20, 2023
Merged

NTT housekeeping #17

merged 6 commits into from
Dec 20, 2023

Conversation

mcarilli
Copy link
Collaborator

@mcarilli mcarilli commented Dec 14, 2023

What ❔

This PR streamlines usage of boojum-cuda's NTT bindings. The diffs aren't super impactful, but i figured they're worth sharing and we can decide which ones to merge.

Why ❔

The diffs reduce code size, improve readability, and improve performance (a little bit) by eliminating host<->device traffic.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via cargo fmt and cargo lint.

@mcarilli mcarilli requested review from saitima and robik75 December 14, 2023 06:24
@mcarilli mcarilli marked this pull request as draft December 14, 2023 06:24
Cargo.toml Outdated Show resolved Hide resolved
@mcarilli mcarilli added refactoring enhancement New feature or request labels Dec 20, 2023
@mcarilli mcarilli marked this pull request as ready for review December 20, 2023 21:46
@mcarilli mcarilli changed the title [WIP] NTT housekeeping NTT housekeeping Dec 20, 2023
@mcarilli mcarilli merged commit 6bf1a12 into main Dec 20, 2023
4 checks passed
@mcarilli mcarilli deleted the mc-ntt-binding-housekeeping branch December 20, 2023 23:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants