This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
Remove local witness generation to align codebase and tests with production usage #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Production does not use "limited" memory. |
saitima
previously approved these changes
Jan 16, 2024
mcarilli
changed the title
mcarilli
changed the title
mcarilli
changed the title
saitima
approved these changes
Jan 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
At a high level, the prover can run in four possible configs: (external witness synthesis, local synthesis) x (all gpu memory, limited memory). In production we use (external, all).
The local-synthesis path adds complex code that we don't really need. After discussion with @robik75 we decided to remove it, pending @saitima's approval.
Why ❔
Removing local synthesis simplifies the codebase, the tests, and Robert's WIP caching improvements.
Checklist
cargo fmtandcargo lint.