This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
merge v1.4.2 #39
Closed
merge v1.4.2 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# What ❔ This PR adds support for the EIP4844 circuit. ## Why ❔ EIP4844 circuit is a special circuit and this PR adds the code needed to support it. ## Checklist - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [x] Documentation comments have been added / updated. - [x] Code has been formatted via `cargo fmt` and linted via `cargo check`.
# What ❔ This PR implements a GpuProofConfig abstraction to remove a dependency on CSReferenceAssembly structure. ## Why ❔ Instantiation of the CSReferenceAssembly structure is expensive so we need to enable the possibility to supply the pieces of configuration the prover needs in an alternative way. This abstraction makes it possible to generate the information either from the CSReferenceAssembly structure or directly from a Circuit structure. ## Checklist - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [x] Documentation comments have been added / updated. - [x] Code has been formatted via `cargo fmt` and linted via `cargo check`.
…ics (#40) # What ❔ * Updated circuit_definitions dependency ## Why ❔ * This new version doesn't export generics anymore, and should compile faster.
# What ❔ This PR updates the boojum-cuda dependency to include fixes for issues introduced with CUDA 12.4.
mcarilli
previously approved these changes
Mar 13, 2024
# What ❔ This PR fixes a bug that surfaces on devices that do not support L2 persistence. ## Why ❔ It's a bug. ## Checklist - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs).
# What ❔ This PR implements a better memory allocation logic to avoid allocation failures in cases where not the whole memory that is reported as free can be actually allocated. ## Why ❔ Attempting to allocate close to all free memory can fail if for example the memory is fragmented. ## Checklist - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Code has been formatted via `cargo fmt` and linted via `cargo check`.
|
superseded by #44 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge changes from the v1.4.2 branch.