-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement compiler backwards compatibility policy #843
Open
elfedy
wants to merge
24
commits into
main
Choose a base branch
from
elfedy-compiler-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+196
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hedgar2017
requested changes
Jan 17, 2025
hedgar2017
previously approved these changes
Jan 18, 2025
Karrq
reviewed
Jan 21, 2025
Karrq
reviewed
Jan 21, 2025
nbaztec
reviewed
Jan 22, 2025
Co-authored-by: Nisheeth Barthwal <[email protected]>
Co-authored-by: Nisheeth Barthwal <[email protected]>
Co-authored-by: Nisheeth Barthwal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
zksolc
versions (1.5.6
onwards). Adding a new version should add the version toZkSolc::zksolc_supported_versions()
and the latest version will be used by default. This keeps version bumping to a single field and also ensures version-aware test suite is run on this new version.1.5.9
explicitly not supported (due to it's suppressed/error warnings not being compatible with the importedzksolc
types).bytecode_hash
not working on1.5.7
and older by adding support for the new field name.TODO: Specifying unsupported versions is signaled as deprecated. A PR removing the support alltogether should be made for the release that follows the one that includes this change.
Why ✋
Addresses #759
Evidence 📷
New tests pass, specifying metadata works for all supported versions.
When specifying an unsupported version:
Documentation 📚
Please ensure the following before submitting your PR: