Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable compilation without Bellman CUDA #31

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

robik75
Copy link
Member

@robik75 robik75 commented Sep 24, 2024

What ❔

This PR enables the compilation without Bellman CUDA in addition to compilation without CUDA Toolkit installation.

@robik75 robik75 requested review from popzxc and EmilLuta September 24, 2024 12:47
@robik75 robik75 self-assigned this Sep 24, 2024
crates/gpu-ffi/build.rs Outdated Show resolved Hide resolved
@robik75 robik75 requested a review from popzxc September 24, 2024 13:25
@robik75 robik75 merged commit 39860f5 into main Sep 25, 2024
13 checks passed
@robik75 robik75 deleted the rr/no-cuda-part-3 branch September 25, 2024 12:45
Copy link
Contributor

@EmilLuta EmilLuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

0xVolosnikov pushed a commit that referenced this pull request Oct 18, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.151.0](v0.150.9...v0.151.0)
(2024-10-18)


### ⚠ BREAKING CHANGES

* fflonk
([#28](#28))

### Features

* Bump `zksync-protocol` to 0.150.6
([#34](#34))
([43704f3](43704f3))
* enable compilation without Bellman CUDA
([#31](#31))
([39860f5](39860f5))
* fflonk
([#28](#28))
([acd71d8](acd71d8))


### Bug Fixes

* Attempt to pin github runner to 22.04.1
([#36](#36))
([ddb7311](ddb7311))


### Reverts

* "feat!: fflonk"
([#33](#33))
([dccaaa6](dccaaa6))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants