Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bump zksync-protocol to 0.150.6 #34

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

0xVolosnikov
Copy link
Contributor

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@0xVolosnikov 0xVolosnikov requested a review from EmilLuta October 16, 2024 20:21
@EmilLuta EmilLuta requested a review from robik75 October 17, 2024 06:21
@EmilLuta
Copy link
Contributor

@robik75 is the test expected to fail?

@0xVolosnikov
Copy link
Contributor Author

@EmilLuta I don't think so.
@robik75 could you please help with debugging (I do not have a local setup to check it)? Looks like the failing test is in shivini:
test::zksync::compare_proofs_for_all_zksync_circuits

@0xVolosnikov
Copy link
Contributor Author

Most likely we need to update some test artifacts

@robik75
Copy link
Member

robik75 commented Oct 17, 2024

The test should not fail but this looks more like some problem with the runner then the code itself, I restarted the job.

@robik75
Copy link
Member

robik75 commented Oct 17, 2024

It failed again, I will try to run it locally.

@robik75
Copy link
Member

robik75 commented Oct 17, 2024

The test is failing because the deserialization of the ManVM leaf circuit is failing, assuming this is because of changes to the circuit. Tests for all other circuits are passing.
The serialized MainVM leaf circuit will have to be replaced but we can merge now anyway and update later.

@robik75 robik75 merged commit 43704f3 into main Oct 17, 2024
12 of 13 checks passed
@robik75 robik75 deleted the vv-bump-protocol-0.150.6 branch October 17, 2024 13:35
0xVolosnikov pushed a commit that referenced this pull request Oct 18, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.151.0](v0.150.9...v0.151.0)
(2024-10-18)


### ⚠ BREAKING CHANGES

* fflonk
([#28](#28))

### Features

* Bump `zksync-protocol` to 0.150.6
([#34](#34))
([43704f3](43704f3))
* enable compilation without Bellman CUDA
([#31](#31))
([39860f5](39860f5))
* fflonk
([#28](#28))
([acd71d8](acd71d8))


### Bug Fixes

* Attempt to pin github runner to 22.04.1
([#36](#36))
([ddb7311](ddb7311))


### Reverts

* "feat!: fflonk"
([#33](#33))
([dccaaa6](dccaaa6))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants