perf: remove CSReferenceAssembly structure instantiation in GPU prover #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robik75
changed the title
EmilLuta
reviewed
Feb 16, 2024
EmilLuta
reviewed
Feb 16, 2024
robik75
force-pushed
the
rr-gpu-config
branch
2 times, most recently
from
76da74c to
65fb4b6
Compare
EmilLuta
approved these changes
Mar 5, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 5, 2024
🤖 I have created a release *beep* *boop* --- ## [12.0.1](prover-v12.0.0...prover-v12.0.1) (2024-03-05) ### Performance Improvements * remove CSReferenceAssembly structure instantiation in GPU prover ([#1100](#1100)) ([5c405ba](5c405ba)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This PR removes an expensive instantiation of a CSReferenceAssembly structure inside the FRI GPU prover.
The prerequisite is matter-labs/era-shivini#37
Why ❔
The instantiation of a CSReferenceAssembly structure is too expensive and needed to be replaced with a faster alternative.
Checklist
zk fmtandzk lint.zk spellcheck.zk linkcheck.