-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Readme To Explain How To Contribute Translations #4918
Enhance Readme To Explain How To Contribute Translations #4918
Conversation
Hello @TomerPacific, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
Thanks, @TomerPacific! Curious to understand why you edited the snap files as part of this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objection to the README changes, but I'm uncertain about the snapshot changes. Adding @sbishel in case he can help route :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with the readme changes, but the snapshots shouldn't be changed...they are causing test failures.
@cwarnermm - My apologies, I saw @ctlaltdieliet's comment about having to run the snapshot command and I thought I might need to do that as well for this PR. I'll revert the changes. |
Thanks, @TomerPacific! The snapshot command details make sense to include as part of this PR, just not the outcome/impact of running the command itself :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Thanks @TomerPacific for your clear instructions on how to contribute to the translations and adding a new language!
Great work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really appreciate your help with this, @TomerPacific!! Thank you!
Windows build issues are known.. |
Summary
Mattermost Boards has transitioned to a community supported plugin called Focalboard. This plugin's string translations are no longer managed using the Mattermost Translation Server.
This PR aims to update the section in the README about contributing translations with all the necessary steps.
Ticket Link
Fixes Issue #6656