Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Readme To Explain How To Contribute Translations #4918

Merged
merged 6 commits into from
Oct 31, 2023
Merged

Enhance Readme To Explain How To Contribute Translations #4918

merged 6 commits into from
Oct 31, 2023

Conversation

TomerPacific
Copy link
Contributor

Summary

Mattermost Boards has transitioned to a community supported plugin called Focalboard. This plugin's string translations are no longer managed using the Mattermost Translation Server.

This PR aims to update the section in the README about contributing translations with all the necessary steps.

Ticket Link

Fixes Issue #6656

@mattermost-build
Copy link
Contributor

Hello @TomerPacific,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@cwarnermm cwarnermm added 2: Dev Review Requires review by a core committer 2. Editor Review labels Oct 30, 2023
@cwarnermm
Copy link
Contributor

Thanks, @TomerPacific! Curious to understand why you edited the snap files as part of this PR?

Copy link

@lieut-data lieut-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objection to the README changes, but I'm uncertain about the snapshot changes. Adding @sbishel in case he can help route :)

Copy link
Collaborator

@sbishel sbishel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the readme changes, but the snapshots shouldn't be changed...they are causing test failures.

@TomerPacific
Copy link
Contributor Author

@cwarnermm - My apologies, I saw @ctlaltdieliet's comment about having to run the snapshot command and I thought I might need to do that as well for this PR. I'll revert the changes.

@cwarnermm
Copy link
Contributor

Thanks, @TomerPacific! The snapshot command details make sense to include as part of this PR, just not the outcome/impact of running the command itself :)

Copy link
Contributor

@ctlaltdieliet ctlaltdieliet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
Thanks @TomerPacific for your clear instructions on how to contribute to the translations and adding a new language!
Great work

Copy link
Contributor

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really appreciate your help with this, @TomerPacific!! Thank you!

@sbishel
Copy link
Collaborator

sbishel commented Oct 31, 2023

Windows build issues are known..

@sbishel sbishel merged commit 28ec2b3 into mattermost-community:main Oct 31, 2023
16 of 18 checks passed
@TomerPacific TomerPacific deleted the feature/translations-contribution branch October 31, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer Contributor Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help Wanted: Document how to contribute Focalboard translations
6 participants