New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error in PhantomJS caused by let keyword #59

Open

chrisdpeters wants to merge 1 commit into mattmccray:master from liveeditor:master

chrisdpeters commented Feb 5, 2017

This is a small one, but pulling Liquid.js into my Ember app causes issues when running the tests in PhantomJS 2.1.1 (latest).

I end up this fun error:

Global error: SyntaxError: Expected an identifier but found 'varLeft' instead

And then a bunch of stuff from Ember fails after that.

I love the new distinction between var, let, and const, and modern browsers seem OK with it, but unfortunately PhantomJS doesn't. :(


          Fix error in PhantomJS caused by let keyword

e20721d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet