Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made compatible with vue 3 #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sebastiandittrich
Copy link

@sebastiandittrich sebastiandittrich commented Nov 6, 2020

As Vue 3 has kept most of the options API the same, it is only one line of code that needs to be changed.

But you have to compile the templates with the new version of vue-template-compiler, otherwise, the components will not work.

Important: I have not updated the dependencies (important for vue-template-compiler), because I think you are also using the same dependencies to build the examples in the stories folder. Since I didn't want to break those and I am not familiar with how rollup works, I kept package.json unchanged.

@CasperEngl CasperEngl mentioned this pull request Jan 5, 2021
@mattrothenberg
Copy link
Owner

@sebastiandittrich I don't understand this change. Won't this be a breaking change for Vue 2.0 users?

@jechazelle
Copy link

Do you have any news about vue 3 support ? 🙂

@mattrothenberg
Copy link
Owner

I don't, @jechazelle . PRs are welcomed!

@sebastiandittrich
Copy link
Author

@mattrothenberg Sorry for the confusion, I also do not fully understand what this does exactly, as it was a long time ago. It was also not meant as a 100% complete solution, I just wanted to share my issue and the solution with you. Feel free to delete it if you don't need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants