Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll to chromium rev 1359167 #242

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Roll to chromium rev 1359167 #242

merged 2 commits into from
Oct 4, 2024

Conversation

Havunen
Copy link
Contributor

@Havunen Havunen commented Oct 1, 2024

No description provided.

@mattsse mattsse merged commit 96609eb into mattsse:main Oct 4, 2024
7 checks passed
@Sytten
Copy link
Contributor

Sytten commented Oct 23, 2024

Hey @Havunen can I ask you to also update the fetcher when you do an update to the CDP 🙏
I will update it now to make sure it is still compatible, but ideally we keep them in sync.

@Sytten
Copy link
Contributor

Sytten commented Oct 24, 2024

Update from my side, it seems that since chrome-for-testing has been released the chromium builds are all over the place and it is impossible to find a build that is available across all platforms.
Also this CDP is still not released, it is beta and IMO we should revert it since it will cause issues for most users.

@Havunen
Copy link
Contributor Author

Havunen commented Oct 24, 2024

Hmm, maybe we should separate the CDP crate from this repository so it could follow different naming convention? Something to match the revision

@Sytten
Copy link
Contributor

Sytten commented Oct 24, 2024

That actually a good idea, the CDP could follow the repo directly and be updated each time the CDP is changed. Then chromiumoxide oxide would pin the dependency. Puppeteer does that and tag the version to 0.0.<revision>

What do you think @mattsse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants