Parse processor properties #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull out the logic for parsing the commnand line, and pull the command line options into their own class.
Adds a command-line option, -properties If it is specified, load a properties file and add each key and value to the script processor properties.
Perform validation in the parseCommandLine method, for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Matt. Thank you for this tool!
I needed to be able to pass processor properties to one of the scripted processors I am working on.
This patch does two things:
-propertiesthat, like-attrs, specifies a path to a properties file. The contents of this file are mapped to the processor properties.I also tried to consolidate input validation tasks to one place.
Please let me know what I can do to make this a palatable contribution for your project.