Re-merge to correctly merge adapter pattern (PR #51) into master #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brandon Duff <[email protected]>
- pass the adapter to collection fetch from make_brainstem_type - fix code formatting issues around indentations and trailing commas Signed-off-by: Ellie Day <[email protected]>
Signed-off-by: Bobby Brown <[email protected]>
… state - fix lint error around lengthy line of code in make brainstem type Signed-off-by: Ellie Day <[email protected]>
…ded methods in model actions for adapter pattern
…ginal objects Signed-off-by: Ellie Day <[email protected]>
Signed-off-by: Bobby Brown <[email protected]>
Signed-off-by: Ellie Day <[email protected]>
…isting object Signed-off-by: Bobby Brown <[email protected]>
…ainstem-redux into add_adapter_pattern
…redux into add_adapter_pattern
Signed-off-by: Ellie Day <[email protected]>
Signed-off-by: Ellie Day <[email protected]>
Implement initial default adapter for upcoming adapter pattern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mistakenly merged PR #51 into this branch instead of master. This PR merges the linked branch into master. The code was good to go so this PR is merely a formality to correct my merging misstep.