Export external/mds #472
Open
Export external/mds #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanca
reviewed
Aug 12, 2022
| 'import/extensions': ['error', 'always', { | ||
| ignorePackages: true, | ||
| }], | ||
| 'import/extensions': 'off', |
There was a problem hiding this comment.
We might still want this. One of the common "slowness" of webpack is resolving file paths to actual files. If it has to guess which extension it is, it slows it down a bit at a time.
juanca
reviewed
Aug 12, 2022
|
|
||
| it('"serves" on http://localhost', async () => { | ||
| const body = await (await fetch('http://localhost/api/v1/hello')).text(); | ||
|
|
||
| expect(body).toEqual('Hello from MSW!'); | ||
| }); | ||
|
|
||
| it('errors on unhandled requests', async () => { |
There was a problem hiding this comment.
Is this failing? I would assume we want this behavior.
juanca
reviewed
Aug 12, 2022
| @@ -1,5 +1,5 @@ | |||
| /* Downloaded XML file from https://www.currency-iso.org/en/home/tables/table-a1.html and converted to javascript */ | |||
| export default { | |||
| const currencies = { | |||
There was a problem hiding this comment.
Was there a specific reason for this change? I'm curious why this was necessary.
juanca
reviewed
Aug 12, 2022
| expect(await findSelectedOption('test label', 'Option 7')).toBeInTheDocument(); | ||
| expect(await findSelectedOption('test label', 'USD')).toBeInTheDocument(); | ||
| expect(await findSelectedOption('test label', 'Option 9')).toBeInTheDocument(); | ||
| expect(await findSelectedOption('Foo')).toBeInTheDocument(); |
There was a problem hiding this comment.
AFAICT, findSelectedOption takes 2 arguments: findSelectedOption(fieldLabel, optionLabel)
juanca
reviewed
Aug 12, 2022
| @@ -73,7 +71,7 @@ describe('<MultiAutocompleter>', () => { | |||
|
|
|||
| await openOptions('test label'); | |||
|
|
|||
| expect(await findAvailableOption('test label', 'Test Option')).toBeInTheDocument(); | |||
There was a problem hiding this comment.
AFAICT, findAvailableOption(fieldLabel, optionLabel).
|
@bennapp Do we need this still? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This was ran from the rake mds:export helper in bigmaven (that script converts file paths that will only work in bigmaven to relative file paths which are needed for standalone external mds). This also includes many lint fixes that were required from bigmaven.
We also had to make some small configuration changes like changing a linter to get the results of the export green.
Acceptance Criteria
PR upkeep checklist