Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move all integration specs over to the integrations directory #1

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Move all integration specs over to the integrations directory #1

merged 1 commit into from
Mar 30, 2021

Conversation

a-bates
Copy link
Contributor

@a-bates a-bates commented Mar 30, 2021

  • Running the unit specs led us to discover that there were a number of spec files that were inside the spec/unit directory that were, in fact, actually integration specs.
  • Due to this, we'd get a large amount of failures that were attempting to reach out to GoodData. These subsequently fail due to the lack of the appropriate ENVs to get the password for authentication.

@a-bates @aposhiana
Move all integration specs over to the integrations directory
45c7340 
- Running the unit specs led us to discover that there were a number of spec files
  that were inside the spec/unit directory that were, in fact, actually integration
  specs.
- Due to this, we'd get a large amount of failures that were attempting to reach out
  to GoodData. These subsequently fail due to the lack of the appropriate ENVs to get
  the password for authentication.

Co-authored-by: Andrew Aposhian <[email protected]>
@a-bates a-bates requested a review from aposhiana March 30, 2021 21:23
@a-bates a-bates added the enhancement New feature or request label Mar 30, 2021
@aposhiana aposhiana merged commit b093039 into master Mar 30, 2021
@aposhiana aposhiana deleted the migrate_integration_specs branch March 30, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aposhiana aposhiana aposhiana approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-bates @aposhiana