Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise actual errors when failing to successfully run the migration MAQL #4

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

a-bates
Copy link
Contributor

@a-bates a-bates commented Jun 1, 2021

  • Previously, this would fail with the unhelpful error message of "Creating dataset failed".
  • Now, we should actually be able to figure out what's goin' on.

- Previously, this would fail with the unhelpful error message of "Creating dataset failed".
- Now, we should actually be able to figure out what's goin' on.

Co-authored-by: Christian Hansen <[email protected]>
@a-bates a-bates requested a review from a team June 1, 2021 21:55
@a-bates a-bates marked this pull request as draft June 1, 2021 21:55
@a-bates a-bates marked this pull request as ready for review June 1, 2021 21:55
@a-bates
Copy link
Contributor Author

a-bates commented Jun 2, 2021

Dev QA'd by borking up the LDM in GoodData and running a migration.

RuntimeError: [{"error"=>{"parameters"=>["attr.dataset.label"], "requestId"=>"TOTES", "component"=>"Stock::MD", "errorClass"=>"GDC::Exception::User", "message"=>"Object '%s' already exists"}}]```

@a-bates a-bates merged commit 8c3caad into master Jun 2, 2021
@a-bates a-bates deleted the what_do_you_mean_you_want_error_messages branch June 2, 2021 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants