Upgrade muPDF to version 1.22.0 #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,8 +9,25 @@ buildscript { | |||
| /*DJVU CHAIN*/ | |||
| task downloadDjvu { | |||
| doLast { | |||
There was a problem hiding this comment.
Why do you put new exec instuction in doLast and kept
exec {
workingDir file(djvu)
commandLine = ['git', 'checkout', '32ff0948c5bc27c0b7507dba90e726fc941fcc42'/*current master*/]
}
out of it?
There was a problem hiding this comment.
Here I am trying to handle the edge case if we are trying to checkout the commit later then the one known by currently checked out repository. So we first move HEAD by fetching the latest master and then switching to the pinned commit. So we either clone or fetch master before switching to detached HEAD.
|
@nickolay168 I've merged part of this request in 8a4a011 There are still some question above for remaining part |
nickolay168
force-pushed
the
nrovinskiy/upgrade_mupdf
branch
from
313198b
to
8e185e4
Compare
|
@nickolay168, @nick863 Thank you! Merged manually with small changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made some minor changes to Orion Viewer to upgrade muPDF.