-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update angular to V18 and other updates #107
base: master
Are you sure you want to change the base?
Conversation
…eated dynamically
WOW! That's an huge amount of work you've put here 🤯 Very funny to see this project getting some view on /r/beadsprites when I already tried to promote it there in the past 😆 Anyway, thanks again, it will take time for me to review everything, especially since I don't really invest that much into the project (small PRs would have been better, but I won't complain considering all the work you've done!) I'll keep you updated! |
I guess the only controversial change is removing GA. Any rationale? |
I got some errors in the I just took a look at some up to date guides to understand how it could be implemented in Angular One of many guides: https://medium.com/@onsignal/add-google-analytics-to-angular-in-5-simple-steps-8bb81d2d03b7 Info about how to make it possible for the user to allow or deny tracking: I think adding it back could be a new PR |
Cool project!
Found this repository while browsing Reddit and saw that the project was open source.
The latest Angular version is at this time when creating this PR at v18 so I gave it a try to update the entire project.
Starting from Angular V9 to V18, updating one version at a time by following the Angular Update Guide
Major changes: