Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add German Localization 🇩🇪 #514

Merged
merged 4 commits into from
Jan 16, 2024

Conversation

moritzsternemann
Copy link
Contributor

Thanks for making this awesome app! 🙌

Translating technical terms like "secret" is always a bit tricky so kept this one as I think it makes sense for a technical tool like Secretive. Would be awesome if another native speaker could give some feedback!

@maxgoedjen
Copy link
Owner

@moritzsternemann awesome, thanks so much for doing this!

WRT the "secret" naming – it might be easier to translate it as "key?" I use that and secret somewhat interchangeably in English, but I'm not especially attached to it as a "brand" or anything.

@maxgoedjen
Copy link
Owner

Anyway I'll set this to merge as-is, if you feel like translating "secret" to something else will be clearer I'll also be happy to merge any followups to that effect. Thanks again!

@maxgoedjen maxgoedjen enabled auto-merge (squash) January 16, 2024 21:14
@maxgoedjen maxgoedjen merged commit 3d50a99 into maxgoedjen:main Jan 16, 2024
1 check passed
@moritzsternemann
Copy link
Contributor Author

Sorry I left this hanging for so long. Also thought about using "key" instead of secret but there's places where "key" doesn't make much sense either.

I think we are good for now and we can still re-evaluate when there's additional strings to translate. Thanks for merging!

@EmmyGraugans
Copy link

Thanks to @moritzsternemann for providing the translation.

(Very) minor gripe: "Großschreibung ist Glücksache". When things get added (and only then, no need to change it right now), a lot of verbs and adjectives should probably start with a lowercase letter.

Regarding the discussion above re: "key" or "secret": why not "Schlüssel", which is the german word for both? At least in one place the word Schlüssel is already used. Again, nothing that is urgent to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants