Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Japanese translations #546

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Conversation

niw
Copy link
Contributor

@niw niw commented Apr 28, 2024

Problem

There is no Japanese translations added yet.

Solution

Translate all strings in Japanese.

@1024jp
Copy link

1024jp commented Apr 28, 2024

Hi, I am just a passing Japanese native macOS app developer.
I have commented on a few points that could be improved.
As for the rest, I think the quality is completely satisfactory.

@niw niw force-pushed the add_japanese_translations branch from c54d83a to b761728 Compare April 28, 2024 19:35
@niw
Copy link
Contributor Author

niw commented Apr 28, 2024

Hi, I am just a passing Japanese native macOS app developer. I have commented on a few points that could be improved. As for the rest, I think the quality is completely satisfactory.

Thank you, updated with your feedbacks!

**Problem**

There is no Japanese translations added yet.

**Solution**

Translate all strings in Japanese.
@niw niw force-pushed the add_japanese_translations branch from b761728 to 8668b7a Compare April 28, 2024 19:37
@maxgoedjen maxgoedjen enabled auto-merge (squash) April 28, 2024 22:33
@maxgoedjen
Copy link
Owner

Very cool, thank you both!

@maxgoedjen maxgoedjen merged commit fc21018 into maxgoedjen:main Apr 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants