feat(viewport): add caching support for Viewports #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iew` with caching support
maximmaxim345
changed the title
compute_scene
maximmaxim345
force-pushed
the
feat/cache-scene-graph
branch
from
3b6cb20 to
29fdbf7
Compare
maximmaxim345
force-pushed
the
feat/cache-scene-graph
branch
from
29fdbf7 to
7de78e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a efficient caching system for the
Viewportwidget.Only the minimal set of nodes is now rerun on changes to the passed in
ProjectView, considerably speeding up the viewport.Caching is applied to both the
ViewportPlugins, and theSceneGraph.To test it, the
cadarabinary now shows a slowly growing cube.While there are still some issues left to solve (#100 and #104), this implementation should be enough for the time being.