This repository has been archived by the owner on Jun 14, 2023. It is now read-only.
Subtype of hmm.B
and automatic type for outputs
#39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the HMM structure, I think it is best practice to have
B::Vector{<:Distribution{F}}
instead ofB::Vector{Distribution{F}}
see for example the responses to my question here.So far the output type is always
Float64
e.g.y = Vector{Float64}(undef, length(z))
. I believe for discrete distribution this is not ideal.Something like
y = Vector{eltype(eltype(hmm.B))}(undef, length(z))
would detect from the distribution inB
the type.This looks pretty ugly though. Maybe the type of the output distribution could be included in the
hmm
?Moreover, I did not change that but all matrix (in algorithm) type are
Float64
, this could be changed to something related to theT
used inHMM{F,T}
?Thanks for the package.