feat: support T.any for deserialization #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoinesaliba
force-pushed
the
antoine.dealing_with_multiple_types
branch
from
2102a83
to
b792283
Compare
antoinesaliba
commented
Jul 3, 2024
|
|
||
| class Person < T::Struct | ||
| include ActsAsComparable | ||
|
|
||
| const :name, String | ||
| const :age, Integer | ||
| const :ruby_rank, RubyRank | ||
| const :stone_rank, T.any(RubyRank, DiamondRank) |
There was a problem hiding this comment.
let me know if you prefer what you had as ruby_rank and I can just create a different think rather than piggy-backing on what you had
There was a problem hiding this comment.
Cool with piggy backing on this struct 👍🏻
maxveldink
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since my other PR was so quickly replaced, had to find something else to contribute 😉
If you've got a Struct with a property that can be
T.any(...), sorbet-schema will raise a CoercionNotSupportedError because it can't find a coercer for something of the typeT::Private::Types::SimplePairUnion. This PR fixes that so that instead of trying to coerceT::Private::Types::SimplePairUnionit iterates through all the types in that union object and tries coercing into all those types.