-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: Ensure that nested structs will deeply serialize #118
Merged
maxveldink
merged 8 commits into
maxveldink:main
from
tbconroy:serialize-nested-structs
Jul 19, 2024
Merged
fix!: Ensure that nested structs will deeply serialize #118
maxveldink
merged 8 commits into
maxveldink:main
from
tbconroy:serialize-nested-structs
Jul 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxveldink
previously approved these changes
Jul 18, 2024
tbconroy
changed the title
Ensure that nested structs will deeply serialize
fix: Ensure that nested structs will deeply serialize
Jul 18, 2024
maxveldink
requested changes
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to remove the version bump change and we should be good to go!
Co-authored-by: Max VelDink <[email protected]>
Co-authored-by: Max VelDink <[email protected]>
…erialize-nested-structs
maxveldink
changed the title
fix: Ensure that nested structs will deeply serialize
fix!: Ensure that nested structs will deeply serialize
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
HashSerializer
would fail to serialize structs nested more than one level deep even if optionshould_serialize_values
was set totrue.
For example, if we update the Job test objects to have a Money Struct for salary, i.e.:
Then, we serialize the Person:
It should probably be:
The main change is adding a
nested_hash
serializer type tolib/sorbet-schema/t/struct.rb
. This will deep serialize structs to when hashes.This new type is used in
lib/sorbet-schema/serialize_value.rb
so that values of values are recursively serialized.