fix: add sorbet-schema shim for better T:Struct extension compatability #123
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #87
There has been issues with the
deserialize_from
method onT::Struct
in downstream projects where the type had to be cast for the struct. We can useT.attached_class
for this, however it complicates the type check for the underlying serializers here.Further, we have an issue of the sigs for the
T::Struct
extension not being picked up by Tapioca and a shim needing to be in place for that.Instead of adding sigs to the extension, I'm going to try and export the rbi as a shim that should be picked up by Tapioca, and use a slightly less safe call in order to give better type information to callers.