feat(signing-event): add support to sign volume events before exporting to server #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng to server This commit adds support to sign volume events(only if SIGNING_KEY_PATH env is configured) and export the signature along with data to REST based server Signed-off-by: mittachaitu <[email protected]>
…files This commit also does following changes: - Add integration test to verify behavior of volume-event-collector when in-appropriate SIGNING_KEY is configured Signed-off-by: mittachaitu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #14 +/- ##
===========================================
+ Coverage 26.64% 32.02% +5.38%
===========================================
Files 5 10 +5
Lines 334 434 +100
===========================================
+ Hits 89 139 +50
- Misses 235 275 +40
- Partials 10 20 +10
Continue to review full report at Codecov.
|
mittachaitu
force-pushed
the
rsa-implementation
branch
from
e82c840
to
cea5de2
Compare
Signed-off-by: mittachaitu <[email protected]>
mittachaitu
force-pushed
the
rsa-implementation
branch
from
cea5de2
to
7dcfbb8
Compare
Signed-off-by: sai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to sign volume events(only if SIGNING_KEY_PATH
env is configured) and export the signature along with data to configured REST
based server.
Integration test cases:
TODO:
Signed-off-by: mittachaitu [email protected]