[maykinmedia/open-klant#299] Add nginx Open Klant charts #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmursa-dev
force-pushed
the
feature/add-nginx-openklant
branch
from
5454f5f to
cb41ead
Compare
danielmursa-dev
force-pushed
the
feature/add-nginx-openklant
branch
from
04da077 to
d8cbe1b
Compare
|
Deployed with @Tiho0135 on the test cluster and it worked. I don't know what other tests we have to do to see if it works properly? |
danielmursa-dev
changed the title
SilviaAmAm
reviewed
Feb 6, 2025
There was a problem hiding this comment.
The CHANGELOG.md needs updating and the version of the chart needs to be bumped (
charts/charts/openklant/Chart.yaml
Line 6 in 7ae07ca
(Then the readme will also need to be regenerated with helm-docs!)
For the rest seems good
Tiho0135
approved these changes
Feb 11, 2025
danielmursa-dev
force-pushed
the
feature/add-nginx-openklant
branch
3 times, most recently
from
b173c11 to
d53c4db
Compare
|
@SilviaAmAm updated |
danielmursa-dev
force-pushed
the
feature/add-nginx-openklant
branch
from
d53c4db to
b1e379e
Compare
SilviaAmAm
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes maykinmedia/open-klant#299