Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added command to show eHerkenning services. #57

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

joeribekker
Copy link
Member

Running this command will download the service catalog and shows all services for given organisation number.

Example:

$ python manage.py show_services preprod 00000001002564440000

Service provider organization: Gemeente Amsterdam
+-- Service definition: Portal (Portal)
    +-- Service ID: urn:etoegang:DV:00000001002564440000:services:0000
+-- Service definition: Milieuzone (Uw zaken regelen met de gemeente Amsterdam via Mijn Amsterdam)
    +-- Service ID: urn:etoegang:DV:00000001002564440000:services:9017
+-- Service definition: Online aanvragen en wijzigingen (ACC) (Online aanvragen en wijzigingen (ACC))
    +-- Service ID: urn:etoegang:DV:00000001002564440000:services:9016
+-- Service definition: Online aanvragen en wijzigingen - Niveau 2+ (ACC) (Online aanvragen en wijzigingen - Niveau 2+ (ACC))
    +-- Service ID: urn:etoegang:DV:00000001002564440000:services:9015
+-- Service definition: Online aanvragen en wijzigingen - Niveau 2 (ACC) (Online aanvragen en wijzigingen - Niveau 2 (ACC))
    +-- Service ID: urn:etoegang:DV:00000001002564440000:services:9014
+-- Service definition: mijnErfpacht Zakelijk gebruik (mijnErfpacht Zakelijk gebruik)
    +-- Service ID: urn:etoegang:DV:00000001002564440000:services:9018
+-- Service definition: Mijn Erfpacht  professional (Mijn Erfpacht  professional)
    +-- Service ID: urn:etoegang:DV:00000001002564440000:services:9019
+-- Service definition: Formulier voor niet ingezetenen (Form for non-NL citizens)
    +-- Service ID: urn:etoegang:DV:00000001002564440000:services:9111
+-- Service definition: Parkeervergunningen (Parkeervergunningen)
    +-- Service ID: urn:etoegang:DV:00000001002564440000:services:9020
+-- Service definition: Autoluw Oudezijde Acc (Autoluw Oudezijde Acc)
    +-- Service ID: urn:etoegang:DV:00000001002564440000:services:9021
+-- Service definition: TPAC Acc (TPAC Acc)
    +-- Service ID: urn:etoegang:DV:00000001002564440000:services:9022
+-- Service definition: iBurgerzaken Preproductie (Direct uw burgerzaken regelen)
    +-- Service ID: urn:etoegang:DV:00000001002564440000:services:9023
+-- Service definition: Mijn Subsidies (ACC) (Mijn Subsidies (ACC))
    +-- Service ID: urn:etoegang:DV:00000001002564440000:services:9024
+-- Service definition: Mijn Parkeren (Weesp) (ACC) (Mijn Parkeren (Weesp) (ACC))
    +-- Service ID: urn:etoegang:DV:00000001002564440000:services:9026
+-- Service definition: Wonenportaal (ACC) (Wonenportaal (ACC))
    +-- Service ID: urn:etoegang:DV:00000001002564440000:services:9025

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.10%. Comparing base (970d3ed) to head (c72b175).
Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   96.01%   96.10%   +0.08%     
==========================================
  Files          72       73       +1     
  Lines        3216     3260      +44     
==========================================
+ Hits         3088     3133      +45     
+ Misses        128      127       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines 44 to 47
service_provider = tree.xpath(
f"esc:ServiceProvider[esc:ServiceProviderID/text()='{oin}']",
namespaces=NAMESPACES,
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The oin argument is not required, what happens if it is None?



class Command(BaseCommand):
help = "Updates the stored metadata file and prepopulates the db fields."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that this help text matches what the command does?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants