Offer metadata as file for download #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using Content-Disposition attachment offers the file for download to the client rather than viewing it inline. The actual reason the dislaying was botched was because of the content security policy which blocked styles (not sure how that works). However, if that were to be addressed, it leaves the certificate data newlines being displayed as spaces, still producing content that is not ready to copy-and-paste, so downloading a file is the best option.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #77 +/- ##
==========================================
+ Coverage 90.85% 90.86% +0.01%
==========================================
Files 51 51
Lines 1651 1653 +2
Branches 152 152
==========================================
+ Hits 1500 1502 +2
Misses 110 110
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #75
Using Content-Disposition attachment offers the file for download to the client rather than viewing it inline.
The actual reason the dislaying was botched was because of the content security policy which blocked styles (not sure how that works). However, if that were to be addressed, it leaves the certificate data newlines being displayed as spaces, still producing content that is not ready to copy-and-paste, so downloading a file is the best option.