Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add eslint command for generated test file #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BaseInfinity
Copy link
Contributor

This helps to ensure that the test file is formatted correctly for given project instead of trying to figure out formatting code myself.

@mayt
Copy link
Owner

mayt commented Jan 5, 2024

I think it will be cleaner here to use eslint class instead of shelling out to call it on command line. It also gives you more control and separates it from the project’s eslint configuration.

see here: https://eslint.org/docs/latest/integrate/nodejs-api#eslint-class

@BaseInfinity
Copy link
Contributor Author

Oh I like that solution instead! Thanks for the link I'll look into it

@BaseInfinity
Copy link
Contributor Author

I'll most likely be able to get to this in the next couple weeks, I plan to make the suggested changes =)

@BaseInfinity
Copy link
Contributor Author

I've been busy sorry, I don't plan to dive into this again for another month or so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants