Convergence large radius #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strangely enough, Rconv=7 is too large for large order. Not clear why that wasn't a problem in the past.
If order > 5, Rconv =5. Otherwise it is 7
|
@mbakker7 this can be merged ? |
Yes, it can. Still feels a bit unsatisfying. Maybe keep an open issue to look into this. Will make that issue now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rconv = 5 when order > 5
Rconv = 7 when order <= 5
Didn't need to do this in the past.
Did any round-off change in numba?
Better to approximate line-element with Taylor series (as in TTim) than the approximate polynomial we use now.