Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pumping test notebooks #60

Merged
merged 25 commits into from
Feb 13, 2024
Merged

Update pumping test notebooks #60

merged 25 commits into from
Feb 13, 2024

Conversation

dbrakenhoff
Copy link
Collaborator

Not sure how far this is, but the first few notebooks follow the new format I believe.

vcantarella and others added 25 commits August 27, 2021 15:58
Update using import ttim as ttm and change all ttim commands
Fix pandas error for use of append - still gives deprecation warning
Set default figure size and remove setting figure size
Add grid to all graphs
Remove next notebook cell at end
fitm is part of ttim
Pumping Test benchmark notebooks
@dbrakenhoff
Copy link
Collaborator Author

I've added some docs updates to this PR.

@dbrakenhoff dbrakenhoff merged commit e81b27c into dev Feb 13, 2024
7 checks passed
@dbrakenhoff dbrakenhoff deleted the pumpingtests branch February 13, 2024 22:23
@vcantarella
Copy link
Contributor

Hi, I see this has been merged. I guess only the confined notebooks were in the new format. Let me know if you still need help with the other notebooks. Thanks for the final touches @dbrakenhoff .

@dbrakenhoff
Copy link
Collaborator Author

Hi @vcantarella, thanks for your work so far, and no worries, we just wanted to make a new release as we near the final stages of a project we were working on.

If you have time we'd really appreciate your help on the other notebooks. Feel free to submit a new PR and we'll merge it in when you mark it as ready. Just note that the notebooks were moved to the /docs/04pumpingtests folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants