Fix #2534 #2552
Open
Fix #2534 #2552
+145
−160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Joy-less thanks for your fix, do you mind to add a recursion unit test as well? Since you described it on the PR description I think would be great to validate that this changes fix it and avoid regressions in future |
|
@pictos I added the recursion tests. I also updated the test packages which were way out-of-date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #2534 where updating a collection during an iteration fails in shared mode.
Previously, functions like
Collection.Update()would always open and close the database, causing a dispose error when recursion was used. Now, it only closes the database if it was responsible for opening it.I'm not sure that this is the best way to solve the problem. It might be a good idea to open a transaction whenever iterating a collection instead. I would have expected this issue to be more impactful.