-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support CY6C65215 and CY6C65215A #5
base: master
Are you sure you want to change the base?
Conversation
pass # TODO verbose output | ||
else: | ||
match(type): | ||
case CyType.UART_CDC: # TODO we could have two of these! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to handle this case a little bit better in this function. I think what would make sense would be to add two DiscoveredDevice entries to the output when we see a dual channel device. Either that, or make DiscoveredDevice able to hold two different channels from one device.
I tried running
|
Hmmm - I'll look into this. I have worked on it in the last few days, and it's working on my side. But I have more changes I've done, so probably I've fixed this issue already. |
Support the dual channel devices. This is still a WIP.
This PR is to discuss the necessary changes to the scb_context, which are quite extensive.
Discussion on this topic also in PR #2