-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to the EMAC test #429
base: dev/emac-mem-manager-improvements
Are you sure you want to change the base?
Improvements to the EMAC test #429
Conversation
@@ -55,7 +55,7 @@ void test_emac_unicast_long_cb(int opt) | |||
|
|||
// Echo response received | |||
if (opt == INPUT) { | |||
if (++test_step > 50000) { | |||
if (++test_step > 10000) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
50000 iterations made this test very long, and frankly I don't really see the point because there are only 1500 possible lengths that a packet can be, and that's more than enough to fuzz all of them.
|
||
emac_if_add_echo_server_addr(ð_input_frame_data[6]); | ||
if (trace_level & TRACE_ETH_FRAMES) { | ||
printf("INP> LEN %i\r\n\r\n", length); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed this so it will always print that a frame was received regardless of whether its format was correct, for ease of debugging
6b06a72
to
2cf8902
Compare
21744e4
to
75e4ec6
Compare
Ran the new EMAC test on K64F and NUCLEO_F429ZI. It works good! It correctly detected broken multicast filtering on both boards. The STM32F4 issue will be fixed in my next PR, but the K64F one is a longer term project as it's simply unimplemented. |
Summary of changes
This PR does some refactoring and rewriting to improve the EMAC test. I have been working with this test suite a lot the last month or two and ended up making a number of fixes. This includes:
Impact of changes
Migration actions required
Documentation
Pull request type
Test results