Provide JDK version externally #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergej-koscejev
force-pushed
the
refactor/external-jdk-version
branch
from
4db48f0
to
459f57b
Compare
|
@sergej-koscejev who is doing now the publication to github packages? Is this now done from a TC configuration or did we decide to not pubilsh github packages at all any more? |
|
@arimer TeamCity will publish both to GitHub and itemis Repo. |
|
Note: the TeamCity configuration needs to be adapted as soon as this PR is merged. |
* Require the version to be specified externally for publishing. * Use laziness for version, so that the project can still be loaded into the IDE and e.g. tasks listed without having to specify the version. * Clean up and simplify handling of various architectures. * Include `windows-aarch64` into the list of architectures.
sergej-koscejev
force-pushed
the
refactor/external-jdk-version
branch
from
459f57b
to
d829c6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JDK version and build should now be provided via project properties
jdkVersionandjdkBuild, consistent with build.publish.mps.GitHub workflow is changed to test only, publishing to the local Maven repository.
Build is also upgraded to Gradle 8.10.2 and version 5.6.0 of the download plugin.