Tagging.remove_unused_tags should gracefully handle already deleted tags #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irphilli
force-pushed
the
feature/graceful-tag-cleanup
branch
from
b61556e
to
03a4d70
Compare
irphilli
force-pushed
the
feature/graceful-tag-cleanup
branch
from
03a4d70
to
384100b
Compare
irphilli
force-pushed
the
feature/graceful-tag-cleanup
branch
from
384100b
to
f54b728
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Together with https://github.com/salsify/goldiloader, I noticed that the order of how tags/taggings are deleted can cause the
remove_unused_tagscallback to be called multiple times. This is normally fine, however, the callback performs areloadon a tag, and that tag may have already been deleted.remove_unused_tagsshould gracefully handle already deleted tags.