add aks-aso chart #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtzar
requested changes
May 3, 2024
|
I also recommend putting in a basic readme at the root so people know the difference between this chart and the other CAPZ AKS chart. |
Closed
|
Apprently That may be fine for us, or we could consider disabling that check. |
|
No, I think we should adhere to the lint with maintainers. It's easy to add that field in there. The linter doesn't make you maintain the chart if you put your name in there 😅 |
mboersma
added
the
kind/feature
mboersma
reviewed
May 10, 2024
|
/assign |
dtzar
approved these changes
May 14, 2024
|
Oops, sorry @dtzar I added a README.md after you approved this. PTAL whenever you have a chance. |
dtzar
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.