Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python 2.6 support #30

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Python 2.6 support #30

wants to merge 2 commits into from

Conversation

justinfay
Copy link

No description provided.

@mbr
Copy link
Owner

mbr commented Apr 16, 2015

Python2.6 is somewhat of an issue - it's very annoying to support, 2.7 has been out for two years now and I rarely run into it myself. Officially, it is not supported - you can tell by the absence of py26 in the tox environment list =).

I've been toying with the idea of adding py2.6 support (at least for one specific version of simplekv), as pyenv makes it somewhat easier to get ahold of old interpreter version. I haven't figured out if it's worth it though - why are you stuck with 2.6?

@justinfay
Copy link
Author

Hi @mbr thanks for the response, I understand the pain of having to support 2.6 😠 In this particular case it is for deploying on RHEL 6.x where we must use the system Python version.

I opened this pull request as in the projects setup.py you have a section requiring additional requirements for python versions older than 2.7

if sys.version_info < (2, 7):
    tests_require = ['unittest2']
else:
    tests_require = []

so I assumed it was still desirable to support older versions. If you do not wish to support older versions I have no problem with you closing this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants