Implemented option to remove color indicator and to change the width of the pallet type slider #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the developer can remove the color indicator if they doesn't need to show.
Palette type slider width can be changed if the user has set the `displayColorIndicator` to false. If not default value is shown
|
This is nice addition; I hope the author can merge this PR. |
KatWinter
reviewed
Feb 15, 2023
| @@ -290,18 +294,28 @@ class _ColorPickerState extends State<ColorPicker> { | |||
| mainAxisAlignment: MainAxisAlignment.center, | |||
There was a problem hiding this comment.
There's some padding just above this line that looks like this:
padding: const EdgeInsets.fromLTRB(15.0, 5.0, 10.0, 5.0),
When widget.displayColorIndicator is false, could you make it so the left and right padding are both 10? Else we end up with the slider being pushed slightly to the right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the developers can remove the color indicator by setting
displayColorIndicatorto false. the default value istrue. And also to fill the excess space they can change the width of the PalletType slider. You can change this by settingpalletTypeSliderWidth. default value is225which comes from defaultcolorPickerWidth - 75.00. This option is only available when thedisplayColorIndicatoris set to false.